SWF plugin loading breaks in 5.5+embedder

[jeroen]

In 5.5 the embedder does some logic to determine the URL of a plugin. Unfortunately, the logic is wrong (shouldn't be applied? Applied twice?), resulting in a wrongly resolved URL. For example when attempting to load this:

jwplayer('player').setup({
    flashplayer: 'assets/player.swf',
    file: 'assets/bunny.mp4',
    plugins: {
      'assets/qualitymonitor.swf': {}
    }
);

The player is trying to load the following plugin:

assets/assets/qualitymonitor.swf

When removing the assets/ part from the plugin URL though, the player attempts to load this:

./qualitymonitor.swf

So the duplicate assets/ is getting generated somewhere...

[jeroen]

I think I get why this isn't tested. The JS plugin guide provides the option for loading a local Flash-only plugin:

 jwplayer().registerPlugin(id, pluginURL);

I think this option is not needed though. Why would I create a local JS file just for the case of loading my local SWF plugin with the embedder? It's probably better to fix the issue described above and remove the case of loading a local SWF from a local JS.

[zach]

Fixed in 1625