Ticket #1201 (closed enhancement: fixed)

Opened 2 years ago

Last modified 11 months ago

Investigate CSS Inheritance Reset

Reported by: zach Owned by: pablo
Priority: Normal Milestone: Player 6.0 beta
Component: html5 Keywords:
Cc: pablo, jeroen Forum thread:

Description

It appears that if you apply a CSS style to a class / instance of the player wrapper when the player is in HTML5 mode, it can make the player look quite bad when rendered.

We might be able to build a CSS reset mechanism by diffing window.defaultView and window.getComputedStyle

See  http://stackoverflow.com/questions/4471663/window-getcomputedstyle-how-to-discard-properties-with-default-values

Change History

comment:1 Changed 2 years ago by pablo

  • Milestone changed from Player 5.6 to Player 5.7

comment:3 Changed 2 years ago by pablo

  • Milestone changed from Player 5.7 to Player 5.8

comment:4 Changed 2 years ago by pablo

  • Milestone changed from Player 5.8 to Backlog

We need to think about a comprehensive style guide for all HTML elements; let's tackle this as part of 6.x

comment:5 Changed 14 months ago by jeroen

  • Owner changed from zach to pablo
  • Priority set to Normal
  • Milestone changed from Backlog to Player 6.0

As part of 6.0, the player is styled with very specific classes. Additionally, a specific and restricted set of elements (like <span> and <input>) are used.

comment:6 Changed 11 months ago by jeroen

  • Status changed from new to closed
  • Resolution set to fixed

This is fixed differently, by relying on CSS styles instead of inline CSS.

Note: See TracTickets for help on using tickets.