Ticket #1077 (closed enhancement: fixed)

Opened 3 years ago

Last modified 11 months ago

Implement maxwidth controlbar skinning option

Reported by: zach Owned by: pablo
Priority: Normal Milestone: Player 6.0 beta
Component: general Keywords:
Cc: Forum thread: http://www.longtailvideo.com/support/forums/jw-player/player-development-and-customization/12774/skinning-the-player-52-margin-question

Description (last modified by jeroen) (diff)

A max-width option will be very nice for skins that render the controlbar with a margin (like the 6.0 default). This option allows the designer to constrain the width (for large frame sizes or fullscreen), so the bar doesn't feel so stretched and thin (see screenshot).

In terms of the skinning model, maxwidth can simply be an option in the XML. If not set, the width of the controlbar is not constrained.

Attachments

maxwidth.png Download (283.9 KB) - added by jeroen 14 months ago.
Example of a maxwidth skin

Change History

comment:1 Changed 3 years ago by jeroen

  • Milestone changed from Player 5.4 to Player 5.5

comment:2 Changed 2 years ago by jeroen

  • Milestone changed from Player 5.5 to Player 5.6

comment:3 follow-up: ↓ 4 Changed 2 years ago by jeroen

  • Owner set to jeroen

While investigating, we should look into enhancing this for the default skin. The default skin looks good in bottom state today, while the over state isn't so impressive. At the same time, we are moving to over as the default.

comment:4 in reply to: ↑ 3 Changed 2 years ago by jeroen

Replying to jeroen:

While investigating, we should look into enhancing this for the default skin. The default skin looks good in bottom state today, while the over state isn't so impressive. At the same time, we are moving to over as the default.

A setting of 10px will look very nice for the default skin (see the Five / Nacht skins in the repo). It will align the controlbar padding with that of the Dock, plus it will give the image/video some more room when the player isn't that large (e.g. 320/180).

comment:5 Changed 2 years ago by jeroen

  • Owner changed from jeroen to pablo
  • Description modified (diff)

comment:6 Changed 2 years ago by pablo

  • Milestone changed from Player 5.6 to Player 5.7

comment:7 Changed 2 years ago by zach

Pablo wasn't clear as to why this was opened. Just to clarify from the forum post:

"Why on earth someone would use the same margin for sides and bottom ??"

comment:8 Changed 2 years ago by zach

  • Milestone changed from Player 5.7 to Backlog

comment:9 Changed 14 months ago by jeroen

  • Priority set to Normal
  • Summary changed from Margin and Max-Width for controlbar should be investigated to Implement maxwidth controlbar skinning option
  • Description modified (diff)
  • Milestone changed from Backlog to Player 6.0

Changed 14 months ago by jeroen

Example of a maxwidth skin

comment:10 Changed 11 months ago by jeroen

  • Status changed from new to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.