Ticket #1069 (closed bug: fixed)

Opened 3 years ago

Last modified 3 years ago

Plugins block in HTML5 can kill the player

Reported by: zach Owned by: zach
Priority: Milestone: Player 5.4
Component: html5 Keywords:
Cc: Forum thread: http://www.longtailvideo.com/support/forums/jw-player/setup-issues-and-embedding/14679/the-all-new-version-53-%E2%80%A6-issues-using-the-jw-embedder

Description

Instantiating plugins in HTML5 player isn't done in a try/catch block. This means that when a JS plugin is unavailable, the player will die.

This is especially unfortunate because the HTML5 player currently receives the Flash player's plugin block in its config, so all HTML5 players will die if a plugin other than controlbar, playlist, logo, or display is configured.

Change History

comment:1 Changed 3 years ago by zach

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in #1379

comment:2 Changed 3 years ago by zach

  • Status changed from closed to reopened
  • Resolution fixed deleted
  • Forum thread set to http://www.longtailvideo.com/support/forums/jw-player/setup-issues-and-embedding/14679/the-all-new-version-53-%E2%80%A6-issues-using-the-jw-embedder

Not quite fixed, apparently. Update jwplayer.html5.model: 

		if (_model.plugins !== undefined) {
			if (typeof _model.plugins == "string") {
				var userplugins = _model.plugins.split(",");
				for (var userplugin in userplugins) {
					pluginorder.push(userplugins[userplugin].replace(/^\s+|\s+$/g, ""));
				}
			} else {
				for (var plugin in _model.plugins) {
					pluginorder.push(_model.plugins[plugin].replace(/^\s+|\s+$/g, ""));
				}
			}
		}

comment:3 Changed 3 years ago by zach

  • Status changed from reopened to closed
  • Resolution set to fixed

Fixed in 1417

Note: See TracTickets for help on using tickets.