Ticket #461 (closed defect: fixed)
pre-roll not being found when wrapper has empty non-linear block
| Reported by: | paul | Owned by: | paul |
|---|---|---|---|
| Priority: | blocker | Milestone: | OVA for AS3 (v1.0.1) |
| Component: | OVA for AS3 | Version: | OVA for AS3 (trunk) |
| Keywords: | Cc: | ||
| Forum thread: |
Description
Wrapped pre-roll not being found when the wrapper has an empty non-linear block. e.g.
<?xml version="1.0" encoding="utf-8"?>
<VAST version="2.0">
<Ad id="243707314">
<Wrapper>
<AdSystem>dfp</AdSystem>
<VASTAdTagURI> http://v.movad.de/stream.ad?cid=103224</VASTAdTagURI>
<AdTitle/>
<Description/>
<Error> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=66&us=sim&t=1207256 </Error>
<Impression id="wrap"> http://ad.de.doubleclick.net/imp;v7;x;243707314;0-0;2;40397560;10/1;43095739/43113526/1;;~aopt=2/1/ff/2;~okv=;dcmt=text/xml;sz=10x1;pos=1;vpos=1;zz=10x1;player=XXL;s_pid=1589;vtype=1;u=pos=1,vpos=1,tile=5,zz=10x1,r7=1,d1=2,d15=2,v1=2,d4=0,d8=1,d9=2,d10=2,d12=1,i3=4,i4=4,i9=4,i13=2,i26=4,i28=2,i42=3,i44=3,d13=1,f1=1,f2=1,d17=1,c1=1,c2=0,c3=0,c4=0,c5=0,c7=1,c8=0,c9=1,c11=1,c12=1,c13=0,c21=1,c22=0,g0=0,g1=0,x9=1,k1=1,k8=0,x1=0,x2=0,x3=1,x4=0,x5=0,x6=1,x7=0,x8=0,g3=32,k2=2,k3=6,k4=5,k5=2,j1=0,n2=3;showroom=preroll_iad;fv=11;sx=1073;sy=1067;r7=1;d1=2;d15=2;v1=2;d4=0;d8=1;d9=2;d10=2;d12=1;i3=4;i4=4;i9=4;i13=2;i26=4;i2;~cs=x%3f</Impression>
<Impression id="movad_wrap"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=1&us=sim&t=1207256</Impression>
<Impression id="3rdParty">
</Impression>
<Creatives>
<Creative id="Linear">
<Linear>
<Duration>00:00:15</Duration>
<TrackingEvents>
<Tracking event="start"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=10&us=sim&t=1207256 </Tracking>
<Tracking event="midpoint"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=35&us=sim&t=1207256 </Tracking>
<Tracking event="firstQuartile"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=32&us=sim&t=1207256 </Tracking>
<Tracking event="thirdQuartile"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=37&us=sim&t=1207256 </Tracking>
<Tracking event="complete"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=40&us=sim&t=1207256 </Tracking>
<Tracking event="mute"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=14&us=sim&t=1207256 </Tracking>
<Tracking event="unmute"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=15&us=sim&t=1207256 </Tracking>
<Tracking event="fullscreen"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=16&us=sim&t=1207256 </Tracking>
<Tracking event="pause"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=11&us=sim&t=1207256 </Tracking>
<Tracking event="expand"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=3&us=sim&t=1207256 </Tracking>
<Tracking event="collapse"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=4&us=sim&t=1207256 </Tracking>
<Tracking event="acceptInvitation"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=20&us=sim&t=1207256 </Tracking>
<Tracking event="close"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=4&us=sim&t=1207256 </Tracking>
</TrackingEvents>
<VideoClicks>
<ClickTracking id="dfp_internal"> http://ad.de.doubleclick.net/click%3Bh%3Dv8/3c7e/3/0/%2a/s%3B243707314%3B0-0%3B2%3B40397560%3B5940-10/1%3B43095739/43113526/1%3Bu%3Dpos%3D1%2Cvpos%3D1%2Ctile%3D5%2Czz%3D10x1%2Cr7%3D1%2Cd1%3D2%2Cd15%3D2%2Cv1%3D2%2Cd4%3D0%2Cd8%3D1%2Cd9%3D2%2Cd10%3D2%2Cd12%3D1%2Ci3%3D4%2Ci4%3D4%2Ci9%3D4%2Ci13%3D2%2Ci26%3D4%2Ci28%3D2%2Ci42%3D3%2Ci44%3D3%2Cd13%3D1%2Cf1%3D1%2Cf2%3D1%2Cd17%3D1%2Cc1%3D1%2Cc2%3D0%2Cc3%3D0%2Cc4%3D0%2Cc5%3D0%2Cc7%3D1%2Cc8%3D0%2Cc9%3D1%2Cc11%3D1%2Cc12%3D1%2Cc13%3D0%2Cc21%3D1%2Cc22%3D0%2Cg0%3D0%2Cg1%3D0%2Cx9%3D1%2Ck1%3D1%2Ck8%3D0%2Cx1%3D0%2Cx2%3D0%2Cx3%3D1%2C%3B%7Eaopt%3D2/1/ff/2%3B%7Esscs%3D%3fhttp://s0.2mdn.net/dot.gif</ClickTracking>
<ClickTracking id="thirdparty">
</ClickTracking>
<ClickTracking id="movad"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=2&us=sim&t=1207256</ClickTracking>
</VideoClicks>
</Linear>
</Creative>
<Creative id="NonLinear">
<NonLinearAds>
<TrackingEvents>
<Tracking event="start"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=10&us=sim&t=1207256 </Tracking>
<Tracking event="midpoint"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=35&us=sim&t=1207256 </Tracking>
<Tracking event="firstQuartile"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=32&us=sim&t=1207256 </Tracking>
<Tracking event="thirdQuartile"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=37&us=sim&t=1207256 </Tracking>
<Tracking event="complete"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=40&us=sim&t=1207256 </Tracking>
<Tracking event="mute"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=14&us=sim&t=1207256 </Tracking>
<Tracking event="unmute"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=15&us=sim&t=1207256 </Tracking>
<Tracking event="fullscreen"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=16&us=sim&t=1207256 </Tracking>
<Tracking event="pause"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=11&us=sim&t=1207256 </Tracking>
<Tracking event="expand"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=3&us=sim&t=1207256 </Tracking>
<Tracking event="collapse"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=4&us=sim&t=1207256 </Tracking>
<Tracking event="acceptInvitation"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=20&us=sim&t=1207256 </Tracking>
<Tracking event="close"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=4&us=sim&t=1207256 </Tracking>
</TrackingEvents>
</NonLinearAds>
</Creative>
</Creatives>
<Extensions>
<Extension type="dfp">
<AdServingData>
<Industry/>
</AdServingData>
</Extension>
<Extension type="CustomTracking">
<Interaction id="i1"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=70&us=sim&t=1207256</Interaction>
<Interaction id="i2"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=71&us=sim&t=1207256</Interaction>
<Interaction id="i3"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=72&us=sim&t=1207256</Interaction>
<Interaction id="i4"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=73&us=sim&t=1207256</Interaction>
<Interaction id="i5"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=74&us=sim&t=1207256</Interaction>
<Interaction id="i6"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=75&us=sim&t=1207256</Interaction>
<Interaction id="i7"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=76&us=sim&t=1207256</Interaction>
<Interaction id="i8"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=77&us=sim&t=1207256</Interaction>
<Interaction id="i9"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=78&us=sim&t=1207256</Interaction>
<Interaction id="i10"> http://event.movad.de/c.ount?po=7&ci=243707314&ad=1&ho=showroom&c7=2668415&c8=65669&c9=5489806&c10=43095739&c11=VPAIDDFP&et=79&us=sim&t=1207256</Interaction>
</Extension>
</Extensions>
</Wrapper>
</Ad>
</VAST>
Issue is created because OVA ads in the impressions to an empty ad (which will be linear by default) if there are no linear or non-linear ads but there are impressions.
The empty ad is then given the pre-roll ad id and matched so the real ad is never shown.
Changed logic to not add the empty video ad with the impression if a video ad that has a linear or non-linear ad has already been added.
