Ticket #356 (closed defect: fixed)

Opened 15 months ago

Last modified 14 months ago

VPAID non-linear ads do not get <AdParameters>

Reported by: paul Owned by: paul
Priority: critical Milestone: OVA for AS3 (v1.0.1)
Component: OVA for AS3 Version: OVA for AS3 (trunk)
Keywords: Cc:
Forum thread:

Description

OVA is not passing in the <AdParameters> to Non-Linear VPAID ads.

See VPAIDNonLinearAd.startVPAID() for the line with the defect. Compare to VPAIDMediaFile.startVPAID()

Raised by Zach.

Change History

comment:1 Changed 15 months ago by paul

Based on Zach's patch:

  1. adParameters added to the NonLinearVideoAd object during VAST2 parsing
  1. adParameters getter/setter removed from CompanionAd (as they are now in NonLinearVideoAd)
  1. In VPAIDNonLinearAd:

_vpaidWrapper.initAd(Math.floor(width), Math.floor(height), mode, 400, "", environmentVars);

has been changed to:

_vpaidWrapper.initAd(

Math.floor(width),
Math.floor(height),
mode,
400,
(adParameters == null) ? "" : adParameters,
(environmentVars == null) ? "" : environmentVars

);

comment:2 Changed 15 months ago by paul

  • Status changed from new to closed
  • Resolution set to fixed

Done. V1.0.1 RC1 Build 7

comment:3 Changed 14 months ago by paul

Reopened ticket - issue still existed in final 1.0.1 RC1 build because of a code error with the VAST2 ad parameters parsing for non-linears. AdParameter value wasn't being correctly extracted so it wasn't being correctly passed in.

Test case created and code error fixed in 1.0.1 RC2 Build 1.

Note: See TracTickets for help on using tickets.